fix: chip typeahead value placement #1748
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). dojo.widgets – ./🔍 Inspect: https://vercel.com/dojo/dojo.widgets/GDd3j7fhCSaV8sWymhHmoCs3rGo1 widget-test-docs – ./🔍 Inspect: https://vercel.com/dojo/widget-test-docs/89UZhuQZwrEKXrruXhiayKz4WjSH |
Codecov Report
@@ Coverage Diff @@
## master #1748 +/- ##
==========================================
- Coverage 90.46% 90.45% -0.02%
==========================================
Files 94 94
Lines 5152 5155 +3
Branches 1406 1408 +2
==========================================
+ Hits 4661 4663 +2
Misses 241 241
- Partials 250 251 +1
Continue to review full report at Codecov.
|
src/text-input/index.tsx
Outdated
| @@ -8,6 +8,7 @@ import { formatAriaProperties } from '../common/util'; | |||
| import HelperText from '../helper-text/index'; | |||
| import Label from '../label/index'; | |||
| import * as css from '../theme/default/text-input.m.css'; | |||
| import { isArray } from 'util'; | |||
There was a problem hiding this comment.
not sure if this is a correct import
src/text-input/index.tsx
Outdated
| @@ -226,6 +227,11 @@ export const TextInput = factory(function TextInput({ | |||
| const inputFocused = focus.isFocused('input'); | |||
| const autofilled = Boolean(icache.get('autofilled')); | |||
|
|
|||
| let leadingElements; | |||
| if (leading) { | |||
| leadingElements = isArray(leading) ? leading : [leading]; | |||
Type: bug
The following has been addressed in the PR:
.dojorctheme.variant()is added to the root domnodetheme.composelike thisDescription:
This pull request fixes an issue where chip values were not wrapped inline with the input.
Resolves #1742