Support different kinds of button without variants #1751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
This change repurposes the
kind
property of theButton
to define the actual different kinds of button i.e.outlined
,text
andcontained
as per the material spec. The existing behaviour forkind
in the button has been removed, as the primary and secondary colour are not a "kind". In the future we will look at whether we implement a property to control colour.kind
will be the consistent approach to supporting variants such as outlined, and will update the card and other places to reflect this.This is a breaking changes as RaisedButton and OutlinedButton no longer exist and the default button style is Contained (aka Raised).