Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Dialog material overrides styles more specific #1759

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

agubler
Copy link
Member

@agubler agubler commented Jun 10, 2021

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

Makes the overriding styles for the material theme more specific than the composed styles

@vercel
Copy link

vercel bot commented Jun 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/9mbcU8RdQ4uzqchPHx542CN1bgxg
✅ Preview: https://dojowidgets-git-fork-agubler-dialog-material-css-dojo1.vercel.app

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/72rJUpr1AUV8bcYA1LH3X7ikvCa2
✅ Preview: https://widget-test-docs-git-fork-agubler-dialog-material-css-dojo1.vercel.app

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #1759 (f5938a5) into master (05f2d0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1759   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          95       95           
  Lines        5232     5232           
  Branches     1429     1429           
=======================================
  Hits         4739     4739           
  Misses        241      241           
  Partials      252      252           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f2d0a...f5938a5. Read the comment docs.

@agubler agubler merged commit dcc5a6a into dojo:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants