Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button test updates #233

Merged
merged 3 commits into from
Jun 9, 2017
Merged

Button test updates #233

merged 3 commits into from
Jun 9, 2017

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Jun 9, 2017

Replaces: #133
Resolves #135

@tomdye tomdye added this to the 2017.06 milestone Jun 9, 2017
Copy link
Member

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Only comment I can think of is we could've used sinon for all the assertions that callback events are called, but there's not really any point.

Good to go.

@tomdye
Copy link
Member Author

tomdye commented Jun 9, 2017

@bitpshr I'll raise an issue to revisit all unit tests to use sinon.

@tomdye
Copy link
Member Author

tomdye commented Jun 9, 2017

@bitpshr issue raised: #234

@codecov
Copy link

codecov bot commented Jun 9, 2017

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   99.14%   99.15%   +<.01%     
==========================================
  Files          22       22              
  Lines        1283     1295      +12     
  Branches      379      386       +7     
==========================================
+ Hits         1272     1284      +12     
  Partials       11       11
Impacted Files Coverage Δ
src/button/Button.ts 100% <100%> (ø) ⬆️
src/checkbox/Checkbox.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d4c68...659ab99. Read the comment docs.

@tomdye tomdye merged commit 604a85a into dojo:master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants