-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for next widget-core release #242
Conversation
b092344
to
71c941b
Compare
@@ -229,7 +233,7 @@ registerSuite({ | |||
|
|||
// enter key | |||
closed = false; | |||
widget.sendEvent('keydown', { | |||
widget.sendEvent<TestEventInit>('keydown', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to see if there is a way to make this easier... sigh works for now though
Also, I don't know if you want to address core/global deprecation in this PR or not. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 99.16% 98.95% -0.22%
==========================================
Files 24 24
Lines 1442 1429 -13
Branches 428 413 -15
==========================================
- Hits 1430 1414 -16
- Partials 12 15 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 99.16% 98.95% -0.22%
==========================================
Files 24 24
Lines 1442 1429 -13
Branches 428 413 -15
==========================================
- Hits 1430 1414 -16
- Partials 12 15 +3
Continue to review full report at Codecov.
|
widget-core is now released. |
Type: feature
The following has been addressed in the PR:
Description:
Upgrade for breaking changes expected in the next release of widget-core.
Depends on
widget-core
being released.