Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for next widget-core release #242

Merged
merged 6 commits into from
Jul 6, 2017

Conversation

agubler
Copy link
Member

@agubler agubler commented Jun 26, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Upgrade for breaking changes expected in the next release of widget-core.

Depends on widget-core being released.

@agubler agubler requested review from smhigley, bitpshr and tomdye June 26, 2017 09:09
@agubler agubler requested review from kitsonk and mwistrand June 30, 2017 18:46
@agubler agubler force-pushed the widget-core-upgrade branch from b092344 to 71c941b Compare June 30, 2017 18:46
@@ -229,7 +233,7 @@ registerSuite({

// enter key
closed = false;
widget.sendEvent('keydown', {
widget.sendEvent<TestEventInit>('keydown', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to see if there is a way to make this easier... sigh works for now though

@kitsonk
Copy link
Member

kitsonk commented Jun 30, 2017

Also, I don't know if you want to address core/global deprecation in this PR or not.

@dylans dylans added this to the 2017.07 milestone Jul 4, 2017
@codecov
Copy link

codecov bot commented Jul 6, 2017

Codecov Report

Merging #242 into master will decrease coverage by 0.21%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   99.16%   98.95%   -0.22%     
==========================================
  Files          24       24              
  Lines        1442     1429      -13     
  Branches      428      413      -15     
==========================================
- Hits         1430     1414      -16     
- Partials       12       15       +3
Impacted Files Coverage Δ
src/timepicker/TimePicker.ts 100% <100%> (ø) ⬆️
src/combobox/ComboBox.ts 99.41% <100%> (-0.01%) ⬇️
src/calendar/Calendar.ts 97.51% <87.5%> (-0.64%) ⬇️
src/select/Select.ts 98.03% <92.85%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb57f6...cd7fe0c. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 6, 2017

Codecov Report

Merging #242 into master will decrease coverage by 0.21%.
The diff coverage is 93.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   99.16%   98.95%   -0.22%     
==========================================
  Files          24       24              
  Lines        1442     1429      -13     
  Branches      428      413      -15     
==========================================
- Hits         1430     1414      -16     
- Partials       12       15       +3
Impacted Files Coverage Δ
src/timepicker/TimePicker.ts 100% <100%> (ø) ⬆️
src/combobox/ComboBox.ts 99.41% <100%> (-0.01%) ⬇️
src/calendar/Calendar.ts 97.51% <87.5%> (-0.64%) ⬇️
src/select/Select.ts 98.03% <92.85%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bb57f6...cd7fe0c. Read the comment docs.

@agubler
Copy link
Member Author

agubler commented Jul 6, 2017

widget-core is now released.

@agubler agubler merged commit 467a7e2 into dojo:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants