-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SlidePane and Dialog updates and conversion to Classes #28
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 100% 99.05% -0.95%
==========================================
Files 3 3
Lines 105 106 +1
Branches 44 46 +2
==========================================
Hits 105 105
- Partials 0 1 +1
Continue to review full report at Codecov.
|
Apologies to all for the diffing of |
@bitpshr have pulled your changes into this PR. |
@tomdye I think we need to bump the widget-core version so the CI will pass, then hopefully we can land this. |
Update examples and tests after class conversion
Not sure why this one line isn't covered despite being hit 15 times: https://codecov.io/gh/dojo/widgets/compare/023ecfe575368ecbdfbabf6163f0f77545362085...c28cf622ef916b5ec451f16a46c7e94c6661bf18/diff#D19-47. |
Type: bug / feature
The following has been addressed in the PR:
Description:
null
classes functionality-attr
usageAlign
Converts both slidepane and dialog to use
Classes
Requires
Classes