Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlidePane and Dialog updates and conversion to Classes #28

Merged
merged 18 commits into from
Feb 15, 2017

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Feb 9, 2017

Type: bug / feature

The following has been addressed in the PR:

  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

  • Make use of null classes functionality
  • Drop -attr usage
  • Add Enum for Align
  • Add const for min-width
  • renamed to slidePane
  • dropped camelCase from folder name

Converts both slidepane and dialog to use Classes

Requires

  • Widget-core release
  • Conversion to Classes

@dylans dylans added this to the 2017.02 milestone Feb 9, 2017
@codecov-io
Copy link

codecov-io commented Feb 9, 2017

Codecov Report

Merging #28 into master will decrease coverage by -0.95%.
The diff coverage is 99.05%.

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage     100%   99.05%   -0.95%     
==========================================
  Files           3        3              
  Lines         105      106       +1     
  Branches       44       46       +2     
==========================================
  Hits          105      105              
- Partials        0        1       +1
Impacted Files Coverage Δ
src/main.ts 100% <100%> (ø)
src/dialog/Dialog.ts 100% <100%> (ø)
src/slidepane/SlidePane.ts 98.66% <98.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023ecfe...c28cf62. Read the comment docs.

@tomdye tomdye changed the title Slidepanel update Slidepanel updates Feb 9, 2017
@tomdye tomdye changed the title Slidepanel updates WIP: Slidepanel updates Feb 9, 2017
@tomdye
Copy link
Member Author

tomdye commented Feb 9, 2017

Apologies to all for the diffing of createSlidePane.ts, GH doesn't seem to be happy with it being changed, renamed and moved into a new directory.

@dylans dylans changed the title WIP: Slidepanel updates WIP: SlidePanel updates Feb 9, 2017
@dylans dylans changed the title WIP: SlidePanel updates WIP: SlidePane updates Feb 10, 2017
@tomdye tomdye changed the title WIP: SlidePane updates SlidePane and Dialog updates and conversion to Classes Feb 10, 2017
@tomdye
Copy link
Member Author

tomdye commented Feb 10, 2017

@bitpshr have pulled your changes into this PR.

@bitpshr
Copy link
Member

bitpshr commented Feb 13, 2017

@tomdye I think we need to bump the widget-core version so the CI will pass, then hopefully we can land this.

@tomdye tomdye removed the discussion label Feb 14, 2017
@bitpshr
Copy link
Member

bitpshr commented Feb 14, 2017

@tomdye tomdye merged commit 9424f14 into dojo:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants