Slider functional tests #322
Conversation
| .findByCssSelector(`.${css.input}`) | ||
| .getProperty('value') | ||
| .then((value: string) => { | ||
| currentValue = parseInt(value, 10); |
There was a problem hiding this comment.
I think this works because all the example page sliders are from 0-100, but it's probably worth noting that if that ever changes, this check will fail.
| }) | ||
| .end(); | ||
| } | ||
| } |
There was a problem hiding this comment.
One other potential test: clicking on the UI elements (or at least on the x,y position of the visible UI) sets focus on the <input>
There was a problem hiding this comment.
Added in a bunch of tests for this
pottedmeat
force-pushed
the
slider-functional-tests
branch
from
9b6a78e to
fd9d745
Compare
src/slider/example/index.ts
Outdated
| @@ -65,6 +66,7 @@ export class App extends WidgetBase<WidgetProperties> { | |||
| }), | |||
| v('h1', {}, ['Disabled slider']), | |||
| w(Slider, { | |||
| extraClasses: { root: 's2' }, | |||
There was a problem hiding this comment.
as with label PR, should wrap in a div with a functional test class then use that along with slidercss.root to target.
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 25 25
Lines 1940 1940
Branches 491 491
=======================================
Hits 1897 1897
Misses 20 20
Partials 23 23Continue to review full report at Codecov.
|
pottedmeat
force-pushed
the
slider-functional-tests
branch
2 times, most recently
from
140c574 to
9d6e627
Compare
pottedmeat
force-pushed
the
slider-functional-tests
branch
from
9d6e627 to
8b211bd
Compare
Type: feature
The following has been addressed in the PR:
Description:
Adds basic functional tests for
Dialogbased on lzhoucs's PR #178 with rebasing and updates.Resolves #158