Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making .outputTooltip class on slider themable #540

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

rorticus
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:
Making .outputTooltip class themable by removing it from the fixed CSS and adding it to the theme CSS.

Resolves #533

@rorticus rorticus requested a review from smhigley April 20, 2018 18:41
Copy link
Member

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also do something in @dojo/themes?

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          32       32           
  Lines        2530     2530           
  Branches      642      642           
=======================================
  Hits         2462     2462           
  Misses          9        9           
  Partials       59       59
Impacted Files Coverage Δ
src/slider/index.ts 98.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700579d...c823698. Read the comment docs.

@smhigley smhigley merged commit 8100296 into dojo:master Apr 25, 2018
@dylans dylans added this to the 2.0.0 milestone Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Themed .outputTooltip class missing
3 participants