Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to use @dojo/framework #565

Merged
merged 4 commits into from
Jul 25, 2018
Merged

Conversation

smhigley
Copy link
Contributor

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Resolves #564, depends on dojo/framework#1 and dojo/test-extras#109

@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #565 into master will increase coverage by 2.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   97.29%   99.61%   +2.32%     
==========================================
  Files          32       32              
  Lines        2552     2615      +63     
  Branches      649      749     +100     
==========================================
+ Hits         2483     2605     +122     
- Misses          9       10       +1     
+ Partials       60        0      -60
Impacted Files Coverage Δ
src/title-pane/index.ts 100% <100%> (+1.49%) ⬆️
src/button/index.ts 100% <100%> (ø) ⬆️
src/icon/index.ts 100% <100%> (ø) ⬆️
src/calendar/CalendarCell.ts 100% <100%> (+2.5%) ⬆️
src/slide-pane/index.ts 96.71% <100%> (+6.64%) ⬆️
src/dialog/index.ts 100% <100%> (+1.16%) ⬆️
src/slider/index.ts 100% <100%> (+1.63%) ⬆️
src/tab-controller/index.ts 100% <100%> (+0.89%) ⬆️
src/accordion-pane/index.ts 100% <100%> (ø) ⬆️
src/listbox/ListboxOption.ts 100% <100%> (ø) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b8da1...1b0678a. Read the comment docs.

@bryanforbes bryanforbes requested a review from agubler July 24, 2018 16:40
@bryanforbes bryanforbes merged commit 93fbeae into dojo:master Jul 25, 2018
@bryanforbes bryanforbes deleted the v3-framework-deps branch July 25, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants