Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#616 Text-Input initial changes #621

Closed
wants to merge 19 commits into from

Conversation

tomdye
Copy link
Member

@tomdye tomdye commented Nov 12, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Initial work towards creating a material theme and improved Text-Input.

  • merges enhanced-text-input and text-input
  • adds new callbacks
  • removed old callbacks
  • removes getRootClasses abstraction
  • tidies up functions
  • inlines properties
  • adds some extra classes for material theme
  • updates other widgets to use new text-input api
  • fixes tests
  • moves text-input tests over to use assertionTemplate

Work Towards: #616

@tomdye tomdye force-pushed the 616-material-text-input branch from f79b23f to 7287a2c Compare November 30, 2018 11:58
@tomdye tomdye force-pushed the 616-material-text-input branch from 6a2ed01 to 3200af6 Compare January 25, 2019 11:56
@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #621 into master will decrease coverage by 1.19%.
The diff coverage is 98.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #621     +/-   ##
=========================================
- Coverage   99.05%   97.86%   -1.2%     
=========================================
  Files          43       42      -1     
  Lines        3274     3225     -49     
  Branches      900      894      -6     
=========================================
- Hits         3243     3156     -87     
- Misses         31       69     +38
Impacted Files Coverage Δ
src/grid/widgets/Cell.ts 85.71% <ø> (-14.29%) ⬇️
src/grid/widgets/Header.ts 96.15% <0%> (-3.85%) ⬇️
src/text-area/index.ts 100% <100%> (ø) ⬆️
src/text-input/index.ts 100% <100%> (ø) ⬆️
src/time-picker/index.ts 100% <100%> (ø) ⬆️
src/combobox/index.ts 88.13% <100%> (-11.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55a9be...ee998d7. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 25, 2019

Codecov Report

Merging #621 into master will decrease coverage by 1.19%.
The diff coverage is 98.82%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #621     +/-   ##
=========================================
- Coverage   99.05%   97.86%   -1.2%     
=========================================
  Files          43       42      -1     
  Lines        3274     3225     -49     
  Branches      900      894      -6     
=========================================
- Hits         3243     3156     -87     
- Misses         31       69     +38
Impacted Files Coverage Δ
src/grid/widgets/Cell.ts 85.71% <ø> (-14.29%) ⬇️
src/grid/widgets/Header.ts 96.15% <0%> (-3.85%) ⬇️
src/text-area/index.ts 100% <100%> (ø) ⬆️
src/text-input/index.ts 100% <100%> (ø) ⬆️
src/time-picker/index.ts 100% <100%> (ø) ⬆️
src/combobox/index.ts 88.13% <100%> (-11.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55a9be...66b76d0. Read the comment docs.

@tomdye tomdye changed the title [WIP] #616 Text-Input initial changes #616 Text-Input initial changes Jan 25, 2019
@tomdye tomdye closed this Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant