Popup widget #925
Merged
Popup widget #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been deployed to:
|
aciccarello
approved these changes
Nov 26, 2019
| if (willFit.below) { | ||
| wrapperStyles.top = `${triggerBottom}px`; | ||
| } else { | ||
| wrapperStyles.top = `${triggerTop - wrapperDimensions.size.height}px`; |
There was a problem hiding this comment.
Do we need to handle when it won't fit above or below? I'm thinking this could happen with a mobile phone on landscape.
There was a problem hiding this comment.
I plan for us to tackle left / right positions as a follow up PR / issue
There was a problem hiding this comment.
Should we get an issue posted just so we don't lose track of this?
There was a problem hiding this comment.
I added it to the existing issue already @vansimke
|
This pull request has been deployed to:
|
|
This pull request has been deployed to:
|
vansimke
approved these changes
Nov 26, 2019
ericos
pushed a commit
to ericos/widgets
that referenced
this pull request
Jan 3, 2020
* initial * add width * add basic popup implementation * basic test file * setting up harnass * typed children * adding examples * stubbing node * add tests for popup * add readme * stub scroll / height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
theme.composelike thisDescription:
Adds popup widget and tests
Resolves #924