move progress bar examples #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLMilner
suggested changes
Nov 29, 2019
| import { create, tsx } from '@dojo/framework/core/vdom'; | ||
| import { icache } from '@dojo/framework/core/middleware/icache'; | ||
| import Progress from '@dojo/widgets/progress'; | ||
| import Button from '@dojo/widgets/Button'; |
There was a problem hiding this comment.
I think this is failing because this should be '@dojo/widgets/button';
There was a problem hiding this comment.
Thanks for catching that, @JamesLMilner . I've fixed the import and rebased onto latest master. Care to take another look?
vansimke
force-pushed
the
825-progress-examples
branch
2 times, most recently
from
3037138
to
9068c34
Compare
|
This pull request has been deployed to:
|
tomdye
approved these changes
Dec 12, 2019
tomdye
reviewed
Dec 12, 2019
src/examples/src/config.tsx
Outdated
| @@ -103,6 +103,10 @@ import CloseableDialog from './widgets/dialog/CloseableDialog'; | |||
|
|
|||
| `!has('docs')`; | |||
| import testsContext from './tests'; | |||
| import ProgressWithChangingValues from './widgets/progress/ProgressWithChangingValues'; | |||
There was a problem hiding this comment.
mike can you move these up above the !has('docs') line please and alphabetise them like the others? This helps with conflicts later
vansimke
force-pushed
the
825-progress-examples
branch
2 times, most recently
from
d3c96cb
to
178d27d
Compare
|
This pull request has been deployed to:
|
|
This pull request has been deployed to:
|
1 similar comment
|
This pull request has been deployed to:
|
vansimke
force-pushed
the
825-progress-examples
branch
from
178d27d
to
df9253e
Compare
matt-gadd
reviewed
Dec 12, 2019
src/examples/src/widgets/progress/ProgressWithChangingValues.tsx
Outdated
Show resolved
Hide resolved
matt-gadd
reviewed
Dec 12, 2019
src/examples/src/widgets/progress/ProgressWithChangingValues.tsx
Outdated
Show resolved
Hide resolved
|
This pull request has been deployed to:
|
Co-Authored-By: Matthew Gadd <mgadd@sitepen.com>
Co-Authored-By: Matthew Gadd <mgadd@sitepen.com>
matt-gadd
approved these changes
Dec 12, 2019
|
This pull request has been deployed to:
|
ericos
pushed a commit
to ericos/widgets
that referenced
this pull request
Jan 3, 2020
* move progress bar examples * Update src/examples/src/widgets/progress/ProgressWithChangingValues.tsx Co-Authored-By: Matthew Gadd <mgadd@sitepen.com> * Update src/examples/src/widgets/progress/ProgressWithChangingValues.tsx Co-Authored-By: Matthew Gadd <mgadd@sitepen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug / feature
The following has been addressed in the PR:
theme.composelike thisDescription: Moved progress bar examples to new format and structure
Resolves #825