Port themes over to widgets #932
Conversation
|
This pull request has been deployed to:
|
| @@ -18,6 +17,8 @@ | |||
| /* Make native input invisible */ | |||
| .nativeInput { | |||
| appearance: none; | |||
| -moz-appearance: none; | |||
| -webkit-appearance: none; | |||
There was a problem hiding this comment.
Do we not have auto-prefixing?
There was a problem hiding this comment.
We don't at the moment for the examples application because it runs in the "speed" mode that disables postcss. This is mostly temporary until we add auto prefixing as part of build-app under speed mode. I will raise an issue on both repos to ensure that it is followed.
|
This pull request has been deployed to:
|
agubler
force-pushed
the
move-themes-over
branch
from
255af7f to
ce88ecc
Compare
|
This pull request has been deployed to:
|
| @@ -1,5 +1,4 @@ | |||
| import dojoTheme from '@dojo/themes/dojo'; | |||
| import '@dojo/themes/dojo/index.css'; | |||
There was a problem hiding this comment.
So the CSS will be loaded via @dojo/widgets/theme/dojo?
There was a problem hiding this comment.
Yup themes will be loaded from importing the index of the theme, no longer needs to import the built index.css
| @import './variables.css'; | ||
|
|
||
| .root { | ||
| box-shadow: var(--box-shadow-dimensions-small) var(--color-box-shadow); |
There was a problem hiding this comment.
Just a note, this file will need to be modified with the changes of dojo/themes#105 to ensure that the base component styles are included.
|
This pull request has been deployed to:
|
|
This pull request has been deployed to:
|
* move themes into default * remove theme dep * move dojo and material theme over * use dojo theme from widgets * use variables and base local to the theme * add prefixes for appearance * Add build theme to widgets * Run prettier on css * Update build theme tgz * Update build theme tgz * Use alpha cli-build-theme
Type: feature
The following has been addressed in the PR:
theme.composelike thisDescription:
theme/defaultdirectorydojoandmaterialtheme from@dojo/themes@dojo/cli-build-themealphadefault,dojoandmaterialthemesappearancein CSS, as the build for examples runs in speed mode which disabled postcss.cssextension to prettier configTodo:
Resolves #931