Move HelperText to functional widget #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-gadd
changed the title
|
This pull request has been deployed to:
|
tomdye
reviewed
Dec 2, 2019
| ]} | ||
| > | ||
| {text && ( | ||
| <p key="text" classes={themedCss.text} aria-hidden={'true'} title={text}> |
There was a problem hiding this comment.
this can just be aria-hidden="true". Did you get to the bottom of wether or not this is appropriate?
agubler
approved these changes
Dec 12, 2019
tomdye
approved these changes
Dec 12, 2019
|
This pull request has been deployed to:
|
|
This pull request has been deployed to:
|
1 similar comment
|
This pull request has been deployed to:
|
ericos
pushed a commit
to ericos/widgets
that referenced
this pull request
Jan 3, 2020
* Move HelperText to functional widget/tsx and add theming * Fix the interface name * Update usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
theme.composelike thisDescription:
This PR moves
HelperTextto a functional widget and leverages the theme mixin.