Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing widget entries from the dojorc and the default index #944

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Dec 3, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

  • Adds missing widgets to .dojorc
  • Adds missing css to the default theme
  • Adds check to the github pull request template

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@dojo-site
Copy link

This pull request has been deployed to:

@agubler agubler merged commit 1b241cb into dojo:master Dec 3, 2019
ericos pushed a commit to ericos/widgets that referenced this pull request Jan 3, 2020
* add missing widgets from dojorc and default theme

* update templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants