Added descriptions for all widget properties #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devpaul
commented
Dec 4, 2019
| @@ -6,14 +6,21 @@ import { WidgetBase } from '@dojo/framework/core/WidgetBase'; | |||
| import * as css from '../theme/default/listbox.m.css'; | |||
|
|
|||
| export interface ListboxOptionProperties extends ThemedProperties { | |||
| active?: boolean; | |||
There was a problem hiding this comment.
Heads up: this property wasn't used in the widget.
|
This pull request has been deployed to:
|
|
This pull request has been deployed to:
|
matt-gadd
approved these changes
Dec 4, 2019
ericos
pushed a commit
to ericos/widgets
that referenced
this pull request
Jan 3, 2020
Added descriptions for all widget properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
.dojorctheme.composelike thisDescription:
Adds missing descriptions for all widget properties
Resolves #812