Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added descriptions to all default theme styles #949

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

devpaul
Copy link
Member

@devpaul devpaul commented Dec 5, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

Adds descriptions to all of the default theme styles

Resolves #913

@dojo-site
Copy link

This pull request has been deployed to:

@devpaul devpaul requested a review from agubler December 5, 2019 22:15
.date {
cursor: pointer;
padding: 10px 20px;
text-align: center;
}

/* Hover style for all dates */
.date:hover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to comment on pseudo selectors as I do not believe they make it through to the generated docs.

@tomdye tomdye merged commit 5fe92e1 into dojo:master Dec 6, 2019
@devpaul devpaul deleted the 913-doc-styles branch December 6, 2019 16:54
ericos pushed a commit to ericos/widgets that referenced this pull request Jan 3, 2020
* A bunch of theme descriptions

* The rest of the descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing jsdoc for widget theme classes
3 participants