Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PasswordInput widget #951

Merged
merged 4 commits into from
Dec 6, 2019
Merged

Adding PasswordInput widget #951

merged 4 commits into from
Dec 6, 2019

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Dec 6, 2019

Type: bug / feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:

Adding password input widget, PasswordInput. Is a regular ConstrainedInput widget but with a set type of password and a toggle button to see the password.

Resolves #792

image

image

nicknisi
nicknisi approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@nicknisi nicknisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It doesn't look like you have any reason to update package-lock.json, though. Should this file be omitted from this PR?

@rorticus
Copy link
Contributor Author

rorticus commented Dec 6, 2019

Oops! Yeah probably. Good catch!

@dojo-site
Copy link

This pull request has been deployed to:

@dojo-site
Copy link

This pull request has been deployed to:

@dojo-site
Copy link

This pull request has been deployed to:

@rorticus rorticus merged commit 57031b7 into dojo:master Dec 6, 2019
@rorticus rorticus deleted the issue-792 branch December 6, 2019 19:30
ericos pushed a commit to ericos/widgets that referenced this pull request Jan 3, 2020
@rorticus @ericos
Adding PasswordInput widget (dojo#951)
d0371c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicknisi nicknisi nicknisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Password input widget
3 participants
@rorticus @dojo-site @nicknisi