Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[katana] Display missing default values in command line --help #1815

Closed
notV4l opened this issue Apr 11, 2024 · 5 comments · Fixed by #1861
Closed

[katana] Display missing default values in command line --help #1815

notV4l opened this issue Apr 11, 2024 · 5 comments · Fixed by #1861
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers katana This issue is related to Katana ODHack OnlyDust Hack fest

Comments

@notV4l
Copy link
Collaborator

notV4l commented Apr 11, 2024

Is your feature request related to a problem? Please describe.
The following default values are not displayed :

--validate-max-steps <VALIDATE_MAX_STEPS>
The maximum number of steps available for the account validation logic.

 --invoke-max-steps <INVOKE_MAX_STEPS>
The maximum number of steps available for the account execution logic.

--eth-gas-price <L1_ETH_GAS_PRICE>
The L1 ETH gas price.

--strk-gas-price <L1_STRK_GAS_PRICE>
The L1 STRK gas price.

Describe the solution you'd like
Display default values like other params

-p, --port <PORT>
Port number to listen on.

[default: 5050]
@notV4l notV4l added enhancement New feature or request good first issue Good for newcomers katana This issue is related to Katana labels Apr 11, 2024
@princeibs
Copy link
Contributor

Can I work on this? @notV4l

@glihm glihm added the ODHack OnlyDust Hack fest label Apr 22, 2024
@princeibs
Copy link
Contributor

@notV4l please can you help with resource where I can look up the default values?

@fabrobles92
Copy link
Contributor

@notV4l please can you help with resource where I can look up the default values?

I think you can find some values here:

https://docs.starknet.io/documentation/tools/limits_and_triggers/

@notV4l
Copy link
Collaborator Author

notV4l commented Apr 22, 2024

@notV4l please can you help with resource where I can look up the default values?

well i started to look into it, and i did PR xd

@princeibs
Copy link
Contributor

No worries @notV4l . I'll just look out for another issue

@glihm glihm assigned notV4l and unassigned princeibs Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers katana This issue is related to Katana ODHack OnlyDust Hack fest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants