-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display default values for EnvironmentOptions in katana cli #1861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 70.14% 70.25% +0.10%
==========================================
Files 315 313 -2
Lines 35607 35721 +114
==========================================
+ Hits 24978 25097 +119
+ Misses 10629 10624 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure about the prints. i have some idea about displaying the config on startup and the config types are a bit messy right now, so would rather so would prefer if we dont print anything else for now.
idk why its an issue to diplay more infos but up to you |
Not really an issue with displaying the infos per se, but just wanting to be conservative about the stuff we add unless there's an actual demand for this feature. I was thinking of doing some rework on the node config first before doing any sort change on this side. so tbh its really just me being picky :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fixes #1815
add extra logs at start