-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page info field to connection object #1177
Conversation
ef9a59d
to
dc0f611
Compare
References
|
c496499
to
e30ec7e
Compare
5377830
to
5ffcdd1
Compare
5ffcdd1
to
8c6c2e6
Compare
a93ded8
to
9ff024a
Compare
9ff024a
to
aa6824f
Compare
#ikuzooo Do you mind adding optional
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@broody How can I return Null for nested object?
Ah this is an issue, in the schema, nested objects are by default nullable but then we reject null values. I'll fix this, but for page_info
I think we do want a non-null value object.
2ff6fd4
to
bd686ee
Compare
fc4f0b5
to
99a60bb
Compare
99a60bb
to
7c3e13c
Compare
This PR adds
pageInfo
fields in all connection object exposed by Torii in order to enable server side pagination.