Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model members in GraphQL to camelCase #1215

Merged
merged 16 commits into from
Dec 5, 2023
Merged

Refactor model members in GraphQL to camelCase #1215

merged 16 commits into from
Dec 5, 2023

Conversation

gianalarcon
Copy link
Contributor

@gianalarcon gianalarcon commented Nov 28, 2023 •
edited
Loading

Resolves #1096

  • Subscription and event tests
  • Metadata tests (WIP)
  • Models tests
  • Entity tests

@gianalarcon gianalarcon marked this pull request as ready for review November 30, 2023 17:45
@broody broody added this to the 0.4.0 milestone Dec 1, 2023
@broody
Copy link
Collaborator

broody commented Dec 1, 2023

LGTM! As we chatted, holding off merging till 0.4.0 since it introduces breaking changes to client.

@tarrencev tarrencev merged commit c6d8297 into dojoengine:main Dec 5, 2023
9 checks passed
@gianalarcon gianalarcon mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broody broody broody left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Change model members in graphql from snake_case to camelCase
3 participants
@gianalarcon @broody @tarrencev