Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change sql setup to avoid torii timeout #1543

Merged
merged 3 commits into from
Feb 20, 2024
Merged

change sql setup to avoid torii timeout #1543

merged 3 commits into from
Feb 20, 2024

Conversation

Cheelax
Copy link
Contributor

@Cheelax Cheelax commented Feb 16, 2024

closes this: #1536

tarrencev
tarrencev reviewed Feb 16, 2024
View reviewed changes
bin/torii/src/main.rs Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (ad67093) 70.63%.
Report is 38 commits behind head on main.

Files Patch % Lines
bin/torii/src/main.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1543      +/-   ##
==========================================
+ Coverage   70.06%   70.63%   +0.56%     
==========================================
  Files         236      259      +23     
  Lines       22531    25062    +2531     
==========================================
+ Hits        15786    17702    +1916     
- Misses       6745     7360     +615

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

glihm
glihm approved these changes Feb 17, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @Cheelax to do some tests and track this issue!

@broody broody merged commit 85f6595 into dojoengine:main Feb 20, 2024
11 of 12 checks passed
@glihm glihm mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarrencev tarrencev tarrencev left review comments

@glihm glihm glihm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cheelax @tarrencev @glihm @broody