Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(torii-grpc): Add total_count on RetrieveEntitiesResponse #1545

Merged
merged 4 commits into from
Feb 24, 2024

Conversation

gianalarcon
Copy link
Contributor

Closes #1423

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (374f2bf) 70.06% compared to head (9d6f4ec) 70.42%.
Report is 43 commits behind head on main.

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 0.00% 37 Missing ⚠️
crates/torii/client/src/client/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1545      +/-   ##
==========================================
+ Coverage   70.06%   70.42%   +0.36%     
==========================================
  Files         236      261      +25     
  Lines       22531    25333    +2802     
==========================================
+ Hits        15786    17842    +2056     
- Misses       6745     7491     +746     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broody
Copy link
Collaborator

broody commented Feb 20, 2024

LGTM

Unfortunately, we don't have good testing for grpc yet (opened an issue to track here #1570)

@broody
Copy link
Collaborator

broody commented Feb 23, 2024

Chatted with @gianalarcon, he's still working on grpc testing. I've done some basic manual testing on this PR and it works fine. What do u guys think bout merging this? @glihm @tarrencev

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for a first iteration too.
When testing is up we also may use a CTE instead of doing two queries. 👍

@broody broody merged commit 8c5eecd into dojoengine:main Feb 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Torii] gRPC RetrieveEntities endpoint to also return total count
3 participants