fix(dojo): dont assign ownership to ResourceMetadata on world creation #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrencev
force-pushed
the
removeresourceowner
branch
2 times, most recently
from
3493f06
to
7914a57
Compare
tarrencev
commented
Feb 20, 2024
tarrencev
force-pushed
the
removeresourceowner
branch
from
7914a57
to
7d5123b
Compare
glihm
approved these changes
Feb 21, 2024
tarrencev
force-pushed
the
removeresourceowner
branch
from
7d5123b
to
71ad391
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1566 +/- ##
==========================================
+ Coverage 70.06% 70.66% +0.60%
==========================================
Files 236 264 +28
Lines 22531 25623 +3092
==========================================
+ Hits 15786 18107 +2321
- Misses 6745 7516 +771 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.