Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(sozo): Improve sozo migration output #1571

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Feb 20, 2024

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks your for that sorry for the delay. Let me know if you have questions on the comments! 👍

bin/sozo/src/ops/migration/mod.rs Outdated Show resolved Hide resolved
bin/sozo/src/ops/migration/mod.rs Outdated Show resolved Hide resolved
@hhamud hhamud requested a review from glihm February 21, 2024 22:01
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

image

Looks good to me, or @tarrencev did you have more changes in mind with this issue?

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (374f2bf) 70.06% compared to head (d9d2040) 70.79%.
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   70.06%   70.79%   +0.72%     
==========================================
  Files         236      264      +28     
  Lines       22531    25574    +3043     
==========================================
+ Hits        15786    18104    +2318     
- Misses       6745     7470     +725     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 640e94d into dojoengine:main Feb 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve sozo migrate output
2 participants