Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(katana-db): ensure key/value types implement their respective traits #1776

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 5, 2024

Add simple unit tests for making sure that the types that are used as the key/value types of the tables, implements the Encode/Decode (key) or Compress/Decompress (value) code respectively.

@kariy
Copy link
Member Author

kariy commented Apr 5, 2024

@kariy kariy changed the title add tests for key value traits test(katana-db): ensure key/value types implement their respective traits Apr 5, 2024
@kariy kariy added the katana This issue is related to Katana label Apr 5, 2024
@kariy kariy marked this pull request as ready for review April 5, 2024 13:05
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (9c8b3b0) to head (5287439).
Report is 2 commits behind head on main.

❗ Current head 5287439 differs from pull request most recent head 0f458f7. Consider uploading reports for the commit 0f458f7 to get more accurate results

Files Patch % Lines
crates/katana/storage/db/src/codecs/postcard.rs 0.00% 1 Missing ⚠️
...es/katana/storage/provider/src/providers/db/mod.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
+ Coverage   67.42%   67.48%   +0.05%     
==========================================
  Files         305      305              
  Lines       33523    33558      +35     
==========================================
+ Hits        22603    22646      +43     
+ Misses      10920    10912       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy changed the base branch from roaring-bitmap to change-dupsort April 5, 2024 13:32
@kariy
Copy link
Member Author

kariy commented Apr 6, 2024

Merge activity

  • Apr 5, 9:34 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • Apr 5, 9:37 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 5, 9:38 PM EDT: @kariy merged this pull request with Graphite.

Base automatically changed from change-dupsort to main April 6, 2024 01:36
@kariy kariy merged commit b286efb into main Apr 6, 2024
10 checks passed
@kariy kariy deleted the test/key-value branch April 6, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
katana This issue is related to Katana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant