Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verification of the RPC version #1782

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Apr 5, 2024

Closes #1780.

Ensure the targeted network support the correct starknet RPC specification.

@glihm glihm added the sozo label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 67.41%. Comparing base (fc5ad79) to head (66ed068).
Report is 1 commits behind head on main.

Files Patch % Lines
bin/sozo/src/commands/migrate.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
- Coverage   67.43%   67.41%   -0.03%     
==========================================
  Files         305      305              
  Lines       33521    33531      +10     
==========================================
  Hits        22604    22604              
- Misses      10917    10927      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm merged commit 5015ea1 into dojoengine:main Apr 6, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sozo] add RPC version check
1 participant