fix: incorrect assumption about migration output #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch @lambda-0x, let me know when this is ready to rebase #1784. 👍 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
==========================================
+ Coverage 67.44% 68.42% +0.97%
==========================================
Files 306 307 +1
Lines 33562 33844 +282
==========================================
+ Hits 22637 23158 +521
+ Misses 10925 10686 -239 ☔ View full report in Codecov by Sentry. |
glihm
approved these changes
Apr 11, 2024
matzayonc
pushed a commit
that referenced
this pull request
Apr 12, 2024
* fix: incorrect assumption about migration output * remove unnecessary import
matzayonc
pushed a commit
that referenced
this pull request
Apr 14, 2024
* fix: incorrect assumption about migration output * remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we assumed that there is one to one mapping between contracts in
local_manifestandmigration_outputbut thats not the case becausemigration_outputjust contains contracts that got upgraded/deployed.So now we find the manifest based on its name.