Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(torii): process pending block #1798

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Apr 8, 2024

DOJ-339

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 50.32680% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 70.30%. Comparing base (5f421e1) to head (ac07855).

Files Patch % Lines
crates/torii/core/src/engine.rs 50.38% 64 Missing ⚠️
crates/torii/core/src/sql.rs 47.05% 9 Missing ⚠️
crates/torii/core/src/processors/event_message.rs 0.00% 1 Missing ⚠️
...rates/torii/core/src/processors/metadata_update.rs 0.00% 1 Missing ⚠️
...tes/torii/core/src/processors/store_transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1798      +/-   ##
==========================================
- Coverage   70.37%   70.30%   -0.07%     
==========================================
  Files         315      315              
  Lines       35766    35822      +56     
==========================================
+ Hits        25171    25186      +15     
- Misses      10595    10636      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo changed the title feat: process pending block feat(torii): process pending block Apr 10, 2024
@Larkooo Larkooo requested a review from glihm April 11, 2024 19:47
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, thanks for the work on that @Larkooo!

We should consider the adding the tests on this behavior on the next week milestone.

crates/torii/core/src/engine.rs Outdated Show resolved Hide resolved
crates/torii/core/src/engine.rs Outdated Show resolved Hide resolved
crates/torii/migrations/20240426211245_pending_block.sql Outdated Show resolved Hide resolved
@Larkooo Larkooo merged commit 6a3cbaa into dojoengine:main Apr 26, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants