Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info trace outputs txn hash as hex #1809

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Info trace outputs txn hash as hex #1809

merged 1 commit into from
Apr 10, 2024

Conversation

broody
Copy link
Collaborator

@broody broody commented Apr 10, 2024

Small devex improvement - convert hash to hex and add quotes so double-clicking in terminal selects only the hex

Previously:
2024-04-09T23:48:32.464311Z INFO txpool: Transaction received. hash=3070079164994693211170539684739988933124593645787751782488497078786805917239

New:
2024-04-10T00:06:45.014781Z INFO txpool: Transaction received. hash="0x6d1edbbdb861522d06392eda659499ede0de2d72b00d79eff5513821871a3a4"

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 68.43%. Comparing base (364fe01) to head (a108ae9).

Files Patch % Lines
crates/katana/core/src/pool.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1809   +/-   ##
=======================================
  Coverage   68.42%   68.43%           
=======================================
  Files         307      307           
  Lines       33834    33834           
=======================================
+ Hits        23152    23155    +3     
+ Misses      10682    10679    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

birdbox

@kariy kariy merged commit 11e0881 into main Apr 10, 2024
11 of 12 checks passed
@kariy kariy deleted the info-tx-hash-hex branch April 10, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants