fix: calculate address of all contracts during migration #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
=======================================
Coverage 69.14% 69.15%
=======================================
Files 308 308
Lines 34612 34612
=======================================
+ Hits 23934 23935 +1
+ Misses 10678 10677 -1 ☔ View full report in Codecov by Sentry. |
glihm
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
@lambda-0x we should sync about the migration and split this huge module file into more appropriate functions by documenting them and adjust this to the testing revamp.
Migration will also be impacted by the dojo-core rework.
Let's sync on that. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fix: #1820