-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clean up bin/sozo #1828
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
=======================================
Coverage 68.66% 68.66%
=======================================
Files 307 307
Lines 34064 34064
=======================================
+ Hits 23390 23391 +1
+ Misses 10674 10673 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup @lambda-0x!
We should start also to add comments on different functions that are missing. Event is sometimes the comment may be short, it will at least give context to new developer coming into the project and help continuing with the restructuring / testing. 👍
* refactor: move verify_cairo_version_compatibility to utils module * refactor: move around more things to appropriate places * refactor: make bin/sozo more consistent * fix: paths in test
shouldn't have any behavioural change
its mostly:
*Args::run
method just below its type declaration