Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up bin/sozo #1828

Merged
merged 4 commits into from
Apr 14, 2024
Merged

refactor: clean up bin/sozo #1828

merged 4 commits into from
Apr 14, 2024

Conversation

lambda-0x
Copy link
Collaborator

shouldn't have any behavioural change

its mostly:

  • moved around few things to more appropriate location
  • having the *Args::run method just below its type declaration
  • small things like above

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Attention: Patch coverage is 17.55319% with 155 lines in your changes are missing coverage. Please review.

Project coverage is 68.66%. Comparing base (e9fab2c) to head (9308ffc).

Files Patch % Lines
bin/sozo/src/commands/dev.rs 0.00% 80 Missing ⚠️
bin/sozo/src/commands/migrate.rs 0.00% 46 Missing ⚠️
bin/sozo/src/commands/auth.rs 0.00% 11 Missing ⚠️
bin/sozo/src/commands/clean.rs 0.00% 11 Missing ⚠️
bin/sozo/src/commands/model.rs 0.00% 4 Missing ⚠️
bin/sozo/src/utils.rs 88.88% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         307      307           
  Lines       34064    34064           
=======================================
+ Hits        23390    23391    +1     
+ Misses      10674    10673    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup @lambda-0x!
We should start also to add comments on different functions that are missing. Event is sometimes the comment may be short, it will at least give context to new developer coming into the project and help continuing with the restructuring / testing. 👍

@glihm glihm merged commit 371c121 into main Apr 14, 2024
11 of 12 checks passed
@glihm glihm deleted the bin-sozo-cleanup branch April 14, 2024 13:52
matzayonc pushed a commit that referenced this pull request Apr 14, 2024
* refactor: move verify_cairo_version_compatibility to utils module

* refactor: move around more things to appropriate places

* refactor: make bin/sozo more consistent

* fix: paths in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants