fix(katana): expected module path in json logs #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(i think test failing due to CI using an old cached version of katana) |
kariy
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems like this change was made in: #1702
https://github.com/dojoengine/dojo/pull/1702/files#diff-ffe1d3f22e2ddc3f1f496a1271db7c7b842862592ef71db7692a40be928aeefdR121
where author updated the target to be
katana::cliinstead of default which i think is crate namekatanabecause of which we would never send a signal on channel and any tests running withKatanaRunnerwould timeout and would fail