Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure transaction executions are stored with fork and db providers #1852

Merged
merged 9 commits into from
Apr 22, 2024
Merged

fix: ensure transaction executions are stored with fork and db providers #1852

merged 9 commits into from
Apr 22, 2024

Conversation

glihm
Copy link
Collaborator

@glihm glihm commented Apr 19, 2024

TxExecInfo are required by saya to extract additional information that is not available in the state_diff returned by katana.

@glihm glihm added the katana This issue is related to Katana label Apr 19, 2024
@glihm glihm marked this pull request as draft April 19, 2024 16:49
@glihm glihm marked this pull request as ready for review April 19, 2024 18:01
@glihm glihm requested a review from kariy April 19, 2024 18:01
@codecov Codecov
Copy link

codecov bot commented Apr 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.24561% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.22%. Comparing base (a2412b3) to head (010a151).
Report is 2 commits behind head on main.

Files Patch % Lines
...es/katana/storage/provider/src/providers/db/mod.rs 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   70.32%   70.22%   -0.10%     
==========================================
  Files         309      315       +6     
  Lines       35126    35566     +440     
==========================================
+ Hits        24703    24978     +275     
- Misses      10423    10588     +165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kariy
kariy requested changes Apr 20, 2024
View reviewed changes
crates/katana/storage/db/src/tables.rs Outdated Show resolved Hide resolved
crates/katana/storage/db/src/tables.rs Outdated Show resolved Hide resolved
crates/katana/storage/provider/src/providers/db/mod.rs Outdated Show resolved Hide resolved
crates/katana/storage/provider/src/providers/db/mod.rs Outdated Show resolved Hide resolved
crates/katana/storage/provider/src/providers/db/mod.rs Outdated Show resolved Hide resolved
crates/katana/storage/provider/tests/block.rs Show resolved Hide resolved
@glihm glihm requested a review from kariy April 22, 2024 03:15
kariy
kariy approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glihm glihm merged commit f6510d5 into dojoengine:main Apr 22, 2024
11 of 12 checks passed
@kariy kariy mentioned this pull request Apr 24, 2024
Merged
@glihm glihm deleted the katana/fix/exec-info-storage branch June 14, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kariy kariy kariy approved these changes

Assignees
No one assigned
Labels
katana This issue is related to Katana
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glihm @kariy