Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): exit with non-zero status code if any function call fails #1853

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

lambda-0x
Copy link
Collaborator

@lambda-0x lambda-0x commented Apr 20, 2024

without set -e script would return with zero status code even if few of function calls inside returned with non-zero error code

@lambda-0x lambda-0x requested review from glihm and kariy April 20, 2024 17:03
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 67.44186% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 70.04%. Comparing base (d92decd) to head (a8597d7).

Files Patch % Lines
crates/saya/core/src/prover/program_input.rs 30.00% 7 Missing ⚠️
crates/torii/grpc/src/server/mod.rs 57.14% 3 Missing ⚠️
crates/sozo/ops/src/account.rs 0.00% 2 Missing ⚠️
bin/sozo/src/commands/options/signer.rs 66.66% 1 Missing ⚠️
crates/dojo-world/src/migration/mod.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   70.03%   70.04%           
=======================================
  Files         315      315           
  Lines       35547    35535   -12     
=======================================
- Hits        24897    24892    -5     
+ Misses      10650    10643    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kariy kariy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume the lint changes are from the ones that arent caught by the ci, right ?

@lambda-0x
Copy link
Collaborator Author

i assume the lint changes are from the ones that arent caught by the ci, right ?

yup

@lambda-0x lambda-0x merged commit 010444f into main Apr 21, 2024
11 of 12 checks passed
@lambda-0x lambda-0x deleted the fix-clippy-ci branch April 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants