Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(katana-executor): test events/messages are extracted correctly from tx execution info #1864

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 22, 2024

  • add tests for functions extracting events and messages from the TxExecInfo.
  • remove blockifier's and sir's output [1][2] module as they are pretty much the same exact code.

@kariy
Copy link
Member Author

kariy commented Apr 22, 2024

@kariy kariy changed the title add tests test(katana-executor): add test for util functions + clean up Apr 22, 2024
@kariy kariy marked this pull request as ready for review April 22, 2024 20:55
@kariy kariy changed the title test(katana-executor): add test for util functions + clean up test(katana-executor): test events/messages are extracted correctly from tx execution info Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 94.27861% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 70.35%. Comparing base (d160479) to head (c09be44).
Report is 2 commits behind head on main.

❗ Current head c09be44 differs from pull request most recent head 0a31f14. Consider uploading reports for the commit 0a31f14 to get more accurate results

Files Patch % Lines
...na/executor/src/implementation/blockifier/utils.rs 93.33% 13 Missing ⚠️
crates/katana/executor/src/utils.rs 96.03% 8 Missing ⚠️
...es/katana/executor/src/implementation/sir/utils.rs 0.00% 1 Missing ⚠️
crates/katana/primitives/src/message.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
+ Coverage   70.14%   70.35%   +0.20%     
==========================================
  Files         315      313       -2     
  Lines       35607    35676      +69     
==========================================
+ Hits        24978    25100     +122     
+ Misses      10629    10576      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy
Copy link
Member Author

kariy commented Apr 23, 2024

Merge activity

  • Apr 22, 10:33 PM EDT: @kariy started a stack merge that includes this pull request via Graphite.
  • Apr 22, 10:36 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 22, 10:38 PM EDT: @kariy merged this pull request with Graphite.

Base automatically changed from fix/refactor to main April 23, 2024 02:35
@kariy kariy merged commit b22e2aa into main Apr 23, 2024
10 checks passed
@kariy kariy deleted the fix/test branch April 23, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant