Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event message subscription subscription broker #1885

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Apr 26, 2024

addresses a bug where the event messages subscription service uses the broker item as entities and thus, messes up when the subscription update fires

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 70.37%. Comparing base (c8815a9) to head (625c852).

Files Patch % Lines
crates/torii/graphql/src/object/event_message.rs 0.00% 10 Missing ⚠️
crates/torii/core/src/sql.rs 0.00% 2 Missing ⚠️
crates/torii/core/src/types.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1885      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.01%     
==========================================
  Files         315      315              
  Lines       35761    35766       +5     
==========================================
  Hits        25169    25169              
- Misses      10592    10597       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo changed the title fix: updates bug. use own eventmessage type for broker fix: event message subscription subscription broker Apr 26, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider doing a document / mapping or what's Torii is doing with the different brokers / subscriptions system. Let's catch up on that @Larkooo. :)

@glihm glihm merged commit 5f421e1 into dojoengine:main Apr 26, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants