Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torii external-url arg to support https #1898

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

broody
Copy link
Collaborator

@broody broody commented Apr 27, 2024

Torii's external-url arg to support https scheme, this will help fix the broken subscription queries in the gql playground for Slot hosted Toriis

Current subscription error slot torii:

{
  "error": "Could not connect to websocket endpoint wss://api.cartridge.gg/graphql/ws. Please check if the endpoint url is correct."
}

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 70.29%. Comparing base (6b6219f) to head (b9de655).

Files Patch % Lines
crates/torii/graphql/src/server.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1898      +/-   ##
==========================================
- Coverage   70.30%   70.29%   -0.02%     
==========================================
  Files         315      315              
  Lines       35843    35850       +7     
==========================================
+ Hits        25201    25202       +1     
- Misses      10642    10648       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@broody broody merged commit af9cdf6 into main Apr 28, 2024
10 of 12 checks passed
@broody broody deleted the fix-torii-external-url branch April 28, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants