Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(katana): place import inside its feature scope #1902

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Apr 30, 2024

make sure katana-provider crate is compilable without the default features. currently running cargo check --no-default-features on the crate will return error:

  |
7 | use crate::providers::fork::backend::ForkedBackendError;
  |                       ^^^^ could not find `fork` in `providers`
  |

this change will fix it.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (af9cdf6) to head (540e90e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1902   +/-   ##
=======================================
  Coverage   70.29%   70.30%           
=======================================
  Files         315      315           
  Lines       35850    35850           
=======================================
+ Hits        25201    25203    +2     
+ Misses      10649    10647    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit f7213c5 into dojoengine:main Apr 30, 2024
12 checks passed
@kariy kariy deleted the fix-feature-error branch April 30, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant