-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display contract addresses in sozo migrate plan #1926
display contract addresses in sozo migrate plan #1926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we should print address of contracts, you can see how they are calculated at:
dojo/crates/dojo-world/src/migration/mod.rs
Lines 179 to 180 in 5a3d246
let contract_address = | |
get_contract_address(self.salt(), base_class_hash, &[], world_address); |
8e10765
to
d5a21f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1926 +/- ##
==========================================
+ Coverage 69.73% 69.74% +0.01%
==========================================
Files 314 314
Lines 35631 35646 +15
==========================================
+ Hits 24848 24863 +15
Misses 10783 10783 ☔ View full report in Codecov by Sentry. |
umm looks like a git merge got messed up, can you please rebase your changes to main branch? |
dfd0c10
to
8f0f4d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @stevencartavia!
draft PR for #1908