feat(sozo): print-env subcommand #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
==========================================
- Coverage 69.46% 69.40% -0.07%
==========================================
Files 313 314 +1
Lines 35348 35410 +62
==========================================
+ Hits 24556 24577 +21
- Misses 10792 10833 +41 ☔ View full report in Codecov by Sentry. |
tarrencev
approved these changes
May 6, 2024
bin/sozo/src/commands/print_env.rs
Outdated
|
|
||
| impl PrintEnvArgs { | ||
| pub fn run(self, config: &Config) -> Result<()> { | ||
| trace!("Executing PrintEnv command."); |
There was a problem hiding this comment.
Let's try to namespace all our loggers
There was a problem hiding this comment.
i think a better way would be to use span's for this usecase, instead of printing in each of them. lmk if you have more thoughts on this for now i will add spans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
print-envsubcommand which prints given list of arguments (or no arguments) what values will sozo use for things likeaccount_address,world_address, etc...