Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dojo-bindgen): support new layout types #1954

Merged
merged 21 commits into from
May 29, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented May 13, 2024

add new layout supported types to bindgen

@Larkooo Larkooo changed the title feat: new types in unity bindgen feat(dojo-bindgen): support new layout types May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 62.24490% with 74 lines in your changes are missing coverage. Please review.

Project coverage is 69.28%. Comparing base (03aefc3) to head (bf4cf0d).
Report is 2 commits behind head on main.

Current head bf4cf0d differs from pull request most recent head d545835

Please upload reports for the commit d545835 to get more accurate results.

Files Patch % Lines
crates/dojo-bindgen/src/plugins/typescript/mod.rs 0.00% 49 Missing ⚠️
crates/dojo-bindgen/src/plugins/unity/mod.rs 78.78% 14 Missing ⚠️
...ates/dojo-bindgen/src/plugins/typescript_v2/mod.rs 85.13% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
+ Coverage   67.95%   69.28%   +1.33%     
==========================================
  Files         318      318              
  Lines       37094    37168      +74     
==========================================
+ Hits        25207    25752     +545     
+ Misses      11887    11416     -471     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glihm glihm added the client client libraries label May 15, 2024
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Larkooo thanks for updating the 3 plugins.

If you could re-enable all the plugins then in the test into build.rs this should add some coverage back and test the new types with all modules (I think only typescript v2 is disabled).

Some minor comments after that.

crates/dojo-bindgen/src/plugins/unity/mod.rs Show resolved Hide resolved
@Larkooo
Copy link
Collaborator Author

Larkooo commented May 28, 2024

Finished Typescript V2 new layout types support & disabled typescript bindgen in sozo due to lack of support & maintenance from dojo.js. Addresses #2013

@glihm glihm merged commit 5af2bc6 into dojoengine:main May 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants