-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dojo-bindgen): support new layout types #1954
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 67.95% 69.28% +1.33%
==========================================
Files 318 318
Lines 37094 37168 +74
==========================================
+ Hits 25207 25752 +545
+ Misses 11887 11416 -471 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Larkooo thanks for updating the 3 plugins.
If you could re-enable all the plugins then in the test into build.rs
this should add some coverage back and test the new types with all modules (I think only typescript v2 is disabled).
Some minor comments after that.
Finished Typescript V2 new layout types support & disabled typescript bindgen in sozo due to lack of support & maintenance from dojo.js. Addresses #2013 |
add new layout supported types to bindgen