feat: init calldata for dojo contract #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…awn-and-move that is: * allow ref self only if specified * add world if specified in parameters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
==========================================
+ Coverage 67.96% 68.27% +0.30%
==========================================
Files 318 318
Lines 37093 37352 +259
==========================================
+ Hits 25212 25503 +291
+ Misses 11881 11849 -32 ☔ View full report in Codecov by Sentry. |
|
(merge with main) |
glihm
reviewed
May 26, 2024
There was a problem hiding this comment.
Great work @lambda-0x, some feedback let me know if you have any question.
This PR + the auto-gen of empty overlays files option, it will be very great! (the option should only generate the file if it does not already exist)
lambda-0x
force-pushed
the
sozo-constructor
branch
from
4da7b40
to
54db6ce
Compare
lambda-0x
force-pushed
the
sozo-constructor
branch
from
54db6ce
to
3572870
Compare
glihm
reviewed
May 28, 2024
glihm
changed the title
glihm
approved these changes
May 29, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for specifying custom constructor
fix: #1888
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)