-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(katana): encapsulate all the tx execution logic into a single function #1968
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
- Coverage 69.81% 69.74% -0.07%
==========================================
Files 313 314 +1
Lines 35562 35628 +66
==========================================
+ Hits 24828 24850 +22
- Misses 10734 10778 +44 ☔ View full report in Codecov by Sentry. |
Description
put all the logic that is required for every tx execution (ie building the receipt, exec info, etc) into a single unit of execution (ie
transact
).this allow us to simplify testing/benchmarking tx execution, bcs all the necessary steps are now included in a single function that we can easily test, without having to create the entire
BlockExecutor
trait.Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)