-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(katana): l1/l2 messaging hash computations #1981
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
+ Coverage 69.71% 69.81% +0.10%
==========================================
Files 314 314
Lines 35766 35685 -81
==========================================
- Hits 24933 24913 -20
+ Misses 10833 10772 -61 ☔ View full report in Codecov by Sentry. |
Description
l1 -> l2 messaging should be using a different hash computation, but instead we were using the hash computation for l2 -> l1 message.
this pr adds a new
compute_l1_to_l2_message_hash
function for computing the hash of a l1 -> l2 message.ref : https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/messaging-mechanism/#l1-l2-messages
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)