Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sozo as a dependency of katana-runner crate #1988

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

kariy
Copy link
Member

@kariy kariy commented May 21, 2024

Description

its not being used, and there's not reason to use this as a dependency unless maybe for testing. but its not being used for testing anyway.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.73%. Comparing base (855da31) to head (f499bf8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1988   +/-   ##
=======================================
  Coverage   69.73%   69.73%           
=======================================
  Files         314      314           
  Lines       35654    35654           
=======================================
  Hits        24863    24863           
  Misses      10791    10791           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 22b0c90 into main May 21, 2024
13 checks passed
@kariy kariy deleted the remove-unsused-dep branch May 21, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant