Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(torii-grpc): layout decoding #2011

Merged
merged 2 commits into from
May 28, 2024
Merged

fix(torii-grpc): layout decoding #2011

merged 2 commits into from
May 28, 2024

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented May 27, 2024

fixes the model layout decoding for model metadatas on grpc

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.95%. Comparing base (3a19201) to head (70edc1f).

Files Patch % Lines
crates/torii/grpc/src/server/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
- Coverage   67.96%   67.95%   -0.01%     
==========================================
  Files         318      318              
  Lines       37098    37098              
==========================================
- Hits        25212    25210       -2     
- Misses      11886    11888       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we could have a test in this PR that avoid such breaking changes not being detected, could be great. 🙏

May be a subsequent PR if the test scope if broader.

@Larkooo
Copy link
Collaborator Author

Larkooo commented May 28, 2024

If we could have a test in this PR that avoid such breaking changes not being detected, could be great. 🙏

May be a subsequent PR if the test scope if broader.

It's a GRPC query using the database so I think a potential subsequent PR with a broader scope for the entire GRPC repo would be more appropriate. Like an integration test just like we have in GraphQL.

@Larkooo Larkooo merged commit 1836367 into dojoengine:main May 28, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants