Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: katana runner log path option #2015

Merged
merged 3 commits into from
May 29, 2024

Conversation

EvolveArt
Copy link
Contributor

Description

This PR adds a new log_path option to KatanaRunner. Currently it's hard to debug issues as logs are stored in a temp dir.

Related issue

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.49%. Comparing base (61c6f39) to head (52d845a).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/katana/runner/src/lib.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2015      +/-   ##
==========================================
- Coverage   67.49%   67.49%   -0.01%     
==========================================
  Files         318      318              
  Lines       37898    37899       +1     
==========================================
- Hits        25581    25580       -1     
- Misses      12317    12319       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @EvolveArt!

Even if the runner already have a log_file_path() to get the file path, it is useful to be able to choose the log file path to ease debugging. 👍

@glihm glihm merged commit 0ab7d21 into dojoengine:main May 29, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants