Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dead links #2036

Merged
merged 2 commits into from
Jun 10, 2024
Merged

update dead links #2036

merged 2 commits into from
Jun 10, 2024

Conversation

taikoonwang
Copy link
Contributor

Description

this PR fix issue's part 1. for part 2, I think the proper way to do this is to add a readme, so it's outside the scope of the dead link.

Related issue

#2035

Tests

  • Yes
  • No, because they aren't needed
  • No, because I need help

Added to documentation?

  • README.md
  • Dojo Book
  • No documentation needed

Checklist

  • I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
  • I've linted my code (scripts/clippy.sh, scripts/docs.sh)
  • I've commented my code
  • I've requested a review after addressing the comments

@glihm
Copy link
Collaborator

glihm commented Jun 10, 2024

Hey @taikoonwang good catch.

| for part 2, I think the proper way to do this is to add a readme, so it's outside the scope of the dead link.

Could you detail that?

Also, would you mind fixing the dojoup README link?

@glihm glihm added documentation Improvements or additions to documentation contributor labels Jun 10, 2024
@taikoonwang
Copy link
Contributor Author

Hey @taikoonwang good catch.

| for part 2, I think the proper way to do this is to add a readme, so it's outside the scope of the dead link.

Could you detail that?

Also, would you mind fixing the dojoup README link?

I mean I have no idea how to fix https://book.dojoengine.org/toolchain/dojoup (which is borken),If we just change it to https://book.dojoengine.org/toolchain (which is also borken), Because the whole toolchain missing an overview readme.

image source:

@glihm
Copy link
Collaborator

glihm commented Jun 10, 2024

@taikoonwang got you, thanks for the explanation.
You're right before we had a dedicated section for dojoup. But asdf is simplifying the management of several versions and different installation sources.

Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those fixes @taikoonwang. 🙏

@glihm glihm merged commit 9205009 into dojoengine:main Jun 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants